Re: [PATCH] tracing: Cleanup the convoluted softirq tracepoints

From: H. Peter Anvin
Date: Mon Oct 25 2010 - 18:20:48 EST


On 10/25/2010 03:12 PM, H. Peter Anvin wrote:
>
> On 64 bits, use P6_NOP5; it seems to not suck on any platform.
>
> On 32 bits, 3E 8D 74 26 00 (i.e. DS: + GENERIC_NOP4) seems to at least
> do okay.
>
> I can't say these are the *best* (in fact, they are guaranteed not the
> best on some significant number of chips), but they haven't sucked on
> any chips I have been able to measure -- and are way faster than JMP.
>

This is pure conjecture, I have not measured it, but I suspect in fact
that we could just change the composite nops in nops.h to use a 3E
prefix instead of a separate 90 nop. Some platforms will take a penalty
on the prefix, but that would be balanced against handling two instructions.

The P5 core and others of the same generation might suffer, as it might
have been able to do U+V pipe pairing on two instructions which it
wouldn't for prefixes.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/