Re: [PATCH 10/29] memstick: mspro: create _setup_io helper.

[Maxim Levitsky]

On Mon, 2010-10-25 at 08:25 -0700, Alex Dubov wrote:
> 
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Subject: [PATCH 10/29] memstick: mspro: create _setup_io helper.
> > To: "Alex Dubov" <oakad@xxxxxxxxx>
> > Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > This function contains common parts
> > of IO setup
> > for the state machine, thus reduces the risk
> > of using the state machine in wrong way.
> > 
> 
> 1. This should precede the read_attribute function patch.
Why?

> 2. Coding style. 
checkpatch.pl passed.


-- 
Best regards,
        Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/