Re: [PATCH] wireless/wl1271: remove redundant if-statement v2

From: Luciano Coelho
Date: Tue Oct 26 2010 - 06:29:09 EST


On Mon, 2010-10-25 at 15:30 +0200, ext Nicolas Kaiser wrote:
> wl1271_ps_elp_sleep() is void and cannot return a value.
>
> Signed-off-by: Nicolas Kaiser <nikai@xxxxxxxxx>
> ---
> Sorry for the poor wording of the initial description.
>
> drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
> index 7b3f503..38ccef7 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_event.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_event.c
> @@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
>
> /* go to extremely low power mode */
> wl1271_ps_elp_sleep(wl);
> - if (ret < 0)
> - break;
> break;
> case EVENT_EXIT_POWER_SAVE_FAIL:
> wl1271_debug(DEBUG_PSM, "PSM exit failed");

Reviewed-by: Luciano Coelho <luciano.coelho@xxxxxxxxx>

Thanks! Applied to the wl12xx tree.

--
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/