Re: [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues

[Tejun Heo]

On 10/26/2010 02:14 PM, Tejun Heo wrote:
>>> That said, I think it might be better to just remove the alignment parameter
>>> from the macro and force align to PAGE_SIZE.
>>
>> That's not necessarily good.  Two arches to note:
>>
>> 	arch/x86/kernel/vmlinux.lds.S:  PERCPU(THREAD_SIZE)
> 
> I don't think the current percpu allocator honors alignment larger
> than PAGE_SIZE no matter how large the alignment for the percpu output
> section is.  I'll look into it deeper but I think we might just have
> been lucky and the alignment somehow didn't bite us yet.  The only
> user of THREAD_SIZE mask at this point seems to be cpu_init().  Maybe
> we can remove this requirement.  I'll look into it.

Okay, this was added by commit fe8e0c2 in this merge window.  It's
broken and needs to be reverted.  I'll send a patch to revert it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/