Re: [PATCH 2/14] drivers/usb/gadget/amd5536udc.c: delete double assignment

From: Thomas Dahlmann
Date: Tue Oct 26 2010 - 09:43:25 EST


ACK

Thanks!
Thomas

On 10/26/2010 12:25 PM, Julia Lawall wrote:
From: Julia Lawall<julia@xxxxxxx>

Delete successive assignments to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

//<smpl>
@@
expression i;
@@

*i = ...;
i = ...;
//</smpl>

Signed-off-by: Julia Lawall<julia@xxxxxxx>

---
drivers/usb/gadget/amd5536udc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 9034e03..f8dd726 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3359,7 +3359,6 @@ static int udc_probe(struct udc *dev)
dev_set_name(&dev->gadget.dev, "gadget");
dev->gadget.dev.release = gadget_release;
dev->gadget.name = name;
- dev->gadget.name = name;
dev->gadget.is_dualspeed = 1;

/* init registers, interrupts, ... */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/