RE: [PATCH] input: spi: Driver for SPI data stream driven vibrator

[ilkka.koskinen]

Hi,

>From: ext Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx]
>Sent: 26 October, 2010 14:18
>To: Grant Likely
>Cc: Koskinen Ilkka (Nokia-MS/Tampere); linux-input@xxxxxxxxxxxxxxx;
>dmitry.torokhov@xxxxxxxxx; spi-devel-general@xxxxxxxxxxxxxxxxxxxxx;
>linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH] input: spi: Driver for SPI data stream driven
>vibrator
>
>> > +	if (!einfo->buf) {
>> > +		einfo->buf = kzalloc(datalen, GFP_KERNEL | GFP_DMA);
>> > +		if (!einfo->buf) {
>> > +			ret = -ENOMEM;
>> > +			goto exit;
>> > +		}
>> > +	}
>> > +
>> > +	memcpy(einfo->buf, p->custom_data, datalen);
>>
>> It looks like raw data from userspace is being passed on to the
>> device.  Is this sane?  Is there already a data format used by other
>> vibration/feedback devices that should be used here instead and
>> translated into the form expected by the hardware?
>
>It also seems to be using GFP_DMA not dma_alloc functions which looks a
>bit odd and certainly isn't portable.

Right, I'll change it to the appropriate ones.

Cheers, Ilkka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/