Re: toshiba_acpi.c: Full TOS1900 device support

[Matthew Garrett]

On Tue, Oct 26, 2010 at 01:14:25PM -0600, Azael Avalos wrote:
> 
> -	hci_read1(HCI_LCD_BRIGHTNESS, &value, &hci_result);
> -	if (hci_result == HCI_SUCCESS) {
> -		return (value >> HCI_LCD_BRIGHTNESS_SHIFT);
> -	} else
> -		return -EFAULT;
> +	if (toshiba_acpi.spfc && toshiba_acpi.video_handle) {
> +		status = acpi_evaluate_integer(toshiba_acpi.video_handle,
> +					       "_BQC", NULL, &val);
> +		if (ACPI_SUCCESS(status))
> +			return val;

This doesn't look right. Shouldn't _BQC indicate that it's an ACPI spec 
video device, and thus driven by the ACPI video driver?

> +static void toshiba_input_event(struct input_handle *handle, unsigned int type,
> +			     unsigned int code, int value)
>  {
> -	struct key_entry *key;
> -
> -	for (key = toshiba_acpi_keymap; key->type != KE_END; key++)
> -		if (code == key->code)
> -			return key;
> -
> -	return NULL;
> +	if (type == EV_MSC && code == MSC_SCAN && value == TOSHIBA_FN_SCAN)
> +		schedule_work(&((struct toshiba_acpi_dev *)handle->private)->hotkey_work);
>  }

Ugh. Use i8042_install_filter instead, and just look at the raw i8042 
stream. That'll avoid the ugly strncmp for the device names in order to 
find the right device.

Otherwise things seem reasonably good - it's a fair rewrite, so I'll 
want to read over things a bit more.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/