Re: [RFC PATCH] include/linux/kernel.h: Add config option for pr_fmt(fmt)

[Joe Perches]

On Tue, 2010-10-26 at 11:03 +0200, Jean Delvare wrote:
> On Thu, 21 Oct 2010 19:19:42 -0700, Joe Perches wrote:
> > Change the default #define pr_fmt(fmt) from:
> > 	- #define pr_fmt(fmt) fmt
> > to:
> > 	- #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > This will standard use of prefixes and prevent the
> > addition of new #defines when using pr_<level>.
> I'm all for it!
> > Adds a config option to use the old style if desired.
> Not sure what the idea is. Once  pr_fmt() includes the module name, we
> will drop hard-coded prefixes in all log messages throughout the kernel
> tree. Once this is done, a kernel built with PR_FMT_IS_KBUILD_MODNAME=n
> would become horribly confusing.

True.  The idea is to allow a transition period and remove
this PR_FMT_IS_KBUILD_MODNAME config option later.

> How relevant is the x86 defconfig?
> It doesn't include any hardware-specific driver, does it?

It adds lots of x86 specific drivers...

> I've used the following grep to find them: grep -I 'pr_[a-z]*([^"]'
> Let me know if you have anything better.

Perhaps use -P
"\bpr_(emerg|alert|crit|err|warning|warn|notice|info|cont|debug)\s*\(\s*\"\w+:"

Another way is to use:
strings <vmlinux|other> | grep -P "^<.>\w+:"


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/