Re: situation with signals

From: Al Viro
Date: Wed Oct 27 2010 - 17:37:56 EST


On Wed, Oct 27, 2010 at 05:02:10PM -0400, Chris Metcalf wrote:

> I set aside this thread to look at when I had a minute, and I believe there
> is just one of the signal issues present in the tile code. The fix is to
> reset regs->fault to something other than the "syscall" fault type when
> exiting from do_signal(), so I'll submit that up for 2.6.37 shortly.
>
> Otherwise I think tile is doing things right, though I admit, the signal
> support is pretty deep magic generally.

FWIW, I'd do that in handle_signal() when hitting a syscall restart.
BTW, is everything in your pt_regs safe to modify? I.e. could bogus
values put there by sigreturn lead to something like kernel mode being
retained when you return from syscall or interesting flags being
set, etc.?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/