Re: [PATCH 8/8] fs: Clean up documentation references to inode_lock

From: Al Viro
Date: Fri Oct 29 2010 - 01:17:17 EST


On Fri, Oct 29, 2010 at 02:23:40PM +1100, Dave Chinner wrote:
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 3d4df44..ae5b156 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -80,7 +80,7 @@
> * ->i_mutex
> * ->i_alloc_sem (various)
> *
> - * ->inode_lock
> + * ->inode_wb_list_lock
Huh? Please, kill -> in these two lines, while we are at it.
> * ->sb_lock (fs/fs-writeback.c)
> * ->mapping->tree_lock (__sync_single_inode)
> *
> @@ -98,8 +98,10 @@
> * ->zone.lru_lock (check_pte_range->isolate_lru_page)
> * ->private_lock (page_remove_rmap->set_page_dirty)
> * ->tree_lock (page_remove_rmap->set_page_dirty)
> - * ->inode_lock (page_remove_rmap->set_page_dirty)
> - * ->inode_lock (zap_pte_range->set_page_dirty)
> + * ->inode->i_lock (page_remove_rmap->set_page_dirty)
> + * ->inode_wb_list_lock (page_remove_rmap->set_page_dirty)
> + * ->inode->i_lock (zap_pte_range->set_page_dirty)
> + * ->inode_wb_list_lock (zap_pte_range->set_page_dirty)

Again, bogus ->
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/