Re: Ensure FMODE_NONOTIFY is not set by userspace

From: Eric Paris
Date: Fri Oct 29 2010 - 09:53:03 EST


On Fri, 2010-10-29 at 12:02 +0200, Lino Sanfilippo wrote:
> In fsnotify_open() ensure that FMODE_NONOTIFY is never set by userspace.
> Also always call fsnotify_parent and fsnotify.

Did you find a place where the user was able to set FMODE_NONOTIFY?
That would be a problem. But that's not what is happening here and
that's not what you are fixing.

This is a test if FMODE_NONOTIFY was already set then we do not send
notification about that file. The current code is correct and your
patch breaks it....

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/