Re: [PATCH][resend] m68k,m68knommu: Do not include linux/hardirq.hin asm/irqflags.h

From: Philippe De Muyter
Date: Sat Oct 30 2010 - 01:09:14 EST


Greg, Geert,

On Sat, Oct 30, 2010 at 07:57:30AM +1000, Greg Ungerer wrote:
>
> Hi Geert,
>
> On 30/10/10 02:31, Geert Uytterhoeven wrote:
>> On Fri, Oct 29, 2010 at 16:06, Greg Ungerer<gerg@xxxxxxxxxxxx> wrote:
>>> Philippe DeMuyter noticed this build failure with Linus' current git
>>> tree. I think it is m68k clean too. If all are ok with it I'll
>>> pass it directly to Linus.
>>
>> Sorry, I saw his patch before, but had no spare cycles left for testing.
>>
>> Unfortunately that breaks CONFIG_MMU=y:
>>
>> arch/m68k/include/asm/irqflags.h: In function âarch_local_irq_enableâ:
>> arch/m68k/include/asm/irqflags.h:43: error: implicit declaration of
>> function âhardirq_countâ

Oops. I am sorry.

>>
>> But if you protect the #include<linux/hardirq.h> by #ifdef
>> CONFIG_MMU, I'm happy with
>> it.
>
> Thanks, I'll rework it with that.

Thanks to both of you

Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/