Re: [PATCH] VIA Chrome integrated camera controller driver includesheaders multiple times

From: Jonathan Corbet
Date: Sat Oct 30 2010 - 10:50:10 EST


On Sat, 30 Oct 2010 15:32:32 +0200 (CEST)
Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:

> The VIA Chrome integrated camera controller driver includes both
> 'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.

Well, you see...I have teenage children. So I've gotten very much used
to the idea that you have to ask for anything at *least* twice have any
chance of it actually happening. Beyond that, the VIA controller has
certain adolescent behavior patterns of its own...watch out when it's
in a bad mood...so I just kind of fell into the habit of insisting.
Even then, I've been known to check with gcc -E to be *sure* it got
included.

Seriously, though, I'm not sure how that happened. Obviously:

Acked-by: Jonathan Corbet <corbet@xxxxxxx>

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/