Re: [PATCH 03/10] staging: hv: Convert camel cased struct fieldsin hv.h to lower cases

[Greg KH]

On Mon, Nov 01, 2010 at 09:53:45AM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> 
> Convert camel cased struct fields in hv.h to lower cases
> 
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx>

Why did I get two different copies of some of these patches?  Are they
different?

>  /* The one and only */
> -struct hv_context gHvContext = {
> -	.SynICInitialized	= false,
> -	.HypercallPage		= NULL,
> -	.SignalEventParam	= NULL,
> -	.SignalEventBuffer	= NULL,
> +struct hv_context g_hv_context = {

What is the "g_" for?  Why are you keeping the unneeded, and unwanted
hungarian notation around?  Please don't do that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/