Re: [PATCH 1/4] w35und: Kill empty Mds_Destroy function

From: Pavel Machek
Date: Mon Nov 01 2010 - 17:16:10 EST


On Mon 2010-11-01 22:29:28, Pekka Enberg wrote:
> The Mds_Destroy() function doesn't do anything so kill it.
>
> Cc: Pavel Machek <pavel@xxxxxx>
> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>

ACK.

> ---
> drivers/staging/winbond/mds.c | 5 -----
> drivers/staging/winbond/mds_f.h | 1 -
> drivers/staging/winbond/wbusb.c | 2 --
> 3 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
> index 9ac2c87..90f2cc0 100644
> --- a/drivers/staging/winbond/mds.c
> +++ b/drivers/staging/winbond/mds.c
> @@ -18,11 +18,6 @@ Mds_initial(struct wbsoft_priv *adapter)
> return hal_get_tx_buffer(&adapter->sHwData, &pMds->pTxBuffer);
> }
>
> -void
> -Mds_Destroy(struct wbsoft_priv *adapter)
> -{
> -}
> -
> static void Mds_DurationSet(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes, u8 *buffer)
> {
> struct T00_descriptor *pT00;
> diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
> index d902843..ce8be07 100644
> --- a/drivers/staging/winbond/mds_f.h
> +++ b/drivers/staging/winbond/mds_f.h
> @@ -5,7 +5,6 @@
> #include "core.h"
>
> unsigned char Mds_initial(struct wbsoft_priv *adapter);
> -void Mds_Destroy(struct wbsoft_priv *adapter);
> void Mds_Tx(struct wbsoft_priv *adapter);
> void Mds_SendComplete(struct wbsoft_priv *adapter, struct T02_descriptor *pt02);
> void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *prxdes);
> diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
> index df055ab..82040f4 100644
> --- a/drivers/staging/winbond/wbusb.c
> +++ b/drivers/staging/winbond/wbusb.c
> @@ -863,8 +863,6 @@ static void hal_halt(struct hw_data *pHwData)
>
> static void wb35_hw_halt(struct wbsoft_priv *adapter)
> {
> - Mds_Destroy(adapter);
> -
> /* Turn off Rx and Tx hardware ability */
> hal_stop(&adapter->sHwData);
> #ifdef _PE_USB_INI_DUMP_

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/