Re: [PATCH] tty: prevent SAK to kill init process

From: Jiri Olsa
Date: Tue Nov 02 2010 - 04:55:51 EST


On Mon, Nov 01, 2010 at 12:40:41PM -0700, Eric W. Biederman wrote:
> Jiri Olsa <jolsa@xxxxxxxxxx> writes:
>
> > hi,
> >
> > hitting "Secure Attention Key" on console that's openned
> > by init process, causing panic due to an attempt to kill
> > the init process.
> >
> > Fixing this by skipping the init process in the loop.
>
> This sounds like proper behavior. The goal of SAK is the guarantee that
> no one else has the tty one, and this violates that goal. Which version
> init opens a controlling tty? I expect it is time to deliver SIGCLUE
> to it.
I was using some older upstart version, which kept the console open

I found this log entry in changelog :)

* No longer holds /dev/console open, so the SAK SysRq key will not
kill Upstart. (Bug: #486005)

So probably no need for the patch

sry for noise,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/