Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

From: Felipe Contreras
Date: Tue Nov 02 2010 - 10:18:29 EST


2010/11/2 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>:
> On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote:
>> On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown
>> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> > On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:
>> >
>> >> Âconfig REGULATOR_TWL4030
>> >> Â Â Â bool "TI TWL4030/TWL5030/TWL6030/TPS695x0 PMIC"
>> >> Â Â Â depends on TWL4030_CORE
>> >> + Â Â default y
>> >> Â Â Â help
>> >> Â Â Â Â This driver supports the voltage regulators provided by
>> >> Â Â Â Â this family of companion chips.
>> >
>> > This default is not suitable for non-OMAP platforms, it should be
>> > conditional on OMAP or something if we're going to do this (though
>> > generally we handle this with defconfigs rather than in Kconfig).
>>
>> This would only be enabled when TWL4030_CORE is enabled, so non-OMAP
>> platforms would not get affected.
> Well, all platforms that have TWL4030_CORE will get REGULATOR_TWL4030 by
> default, too. Â(TWL4030_CORE doesn't depend on something omapish.)

Yes, I think TWL4030_CORE should depend on OMAP3, but I think some
people might not like that. That's why I wanted to make that a
separate patch.

> For me this looks OK. ÂIt would be still better if it removed
> CONFIG_REGULATOR_TWL4030=y from arch/arm/configs/omap2plus_defconfig.

Yes, but I want to run 'make savedefconfig'; there's many changes
lingering like that.

--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/