Re: [PATCH] checkpatch.pl: fix CAST detection to not screw withparens handling

From: Audun Hoem
Date: Wed Nov 03 2010 - 11:26:52 EST


On 11/3/10, Florian Mickler <florian@xxxxxxxxxxx> wrote:
> On Wed, 3 Nov 2010 13:04:33 +0100
> Florian Mickler <florian@xxxxxxxxxxx> wrote:
>
>> Casts have to be handled after the last type that is followed by an
>> opening parenthesis is handled.
>
> That is the wrong fix. I realized now that with that patch we would
> not claim anything as a CAST anymore. Better is probably to only claim
> a CAST if av_pending is not set. Andy, would that work? It seems to be
> alright... Do you have some tests for checkpatch?
>
> Testing it with the reported line and some other random samples it
> seems to be alright.
>

Probably good enough of a test to try it on random kernel code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/