Re: [PATCH 3/3] Staging: comedi: fix brace coding style issue inpcl818.c

From: Joe Perches
Date: Wed Nov 03 2010 - 18:32:39 EST


On Wed, 2010-11-03 at 18:19 -0300, Damian Varayud wrote:
> This is a patch to the pcl818.c file that fixes up braces, indentation, printk() and overlines warning
> and error at initializing variable found by the checkpatch.pl tool
> printk
> - ("comedi: A/D mode1/3 FIFO - channel dropout %d!=%d !\n",
> + ("comedi: A/D mode1/3 FIFO - channel "
> + "dropout %d!=%d !\n",

Not an improvement.
Please ignore any checkpatch long line complaints about printk formats.

Another thing you could do would be to convert these to
printk(KERN_ERR
"comedi: A/D mode1/3 FIFO - channel dropout %d!=%d !\n",
etc);

That fixes the missing KERN_<level> and as well doesn't get any
complaint from checkpatch.

[]
> @@ -1753,22 +1800,23 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> /* claim our I/O space */
> iobase = it->options[0];
> - printk("comedi%d: pcl818: board=%s, ioport=0x%03lx",
> + printk(KERN_ERR "comedi%d: pcl818: board=%s, ioport=0x%03lx",
> dev->minor, this_board->name, iobase);
> devpriv->io_range = this_board->io_range;
> - if ((this_board->fifo) && (it->options[2] == -1)) { /* we've board with FIFO and we want to use FIFO */
> + /* we've board with FIFO and we want to use FIFO */
> + if ((this_board->fifo) && (it->options[2] == -1)) {
> devpriv->io_range = PCLx1xFIFO_RANGE;
> devpriv->usefifo = 1;
> }
> if (!request_region(iobase, devpriv->io_range, "pcl818")) {
> - printk("I/O port conflict\n");
> + printk(KERN_ERR "I/O port conflict\n");

Not correct, these and several below are actually
continuation printks not the start of new lines.
The KERN_<level> that should be used is KERN_CONT.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/