Re: [RFC/RFT] OHCI: Fix for regression in 2.6.37-rc1 since commit3df7169e7

From: Larry Finger
Date: Wed Nov 03 2010 - 21:10:42 EST


On 11/03/2010 04:04 PM, Alan Stern wrote:
>
> This patch is definitely wrong -- it defeats the entire purpose of
> rewriting the control register! That write was added _specifically_ to
> put the controller into reset, i.e., to change the functional state.
>
> Furthermore, the write does the same thing as ohci_hcd.c does in its
> ohci_usb_reset() routine. Regardless, ohci_run() does a complete host
> controller reset, which should override anything done in pci-quirks.c.
> Perhaps _that_ routine needs some attention.

It is looking as if your patch is exposing a different bug. When I disable the
write in pci_quirks leaving the controllers in OPER or RESUME mode, then
ohci_run() is not called. I'm still trying to find out why.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/