Re: Linux 2.6.37-rc1 (floppy module load: no device found)

[Randy Dunlap]

On 11/05/10 16:36, Linus Torvalds wrote:
> On Fri, Nov 5, 2010 at 4:03 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>> On 11/05/10 15:10, Linus Torvalds wrote:
>>>
>>> Randy, is this one also related to that ipv6 percpu list corruption?
>>> IOW, does it go away with
>>>
>>>   http://patchwork.ozlabs.org/patch/69939/
>>>
>>> like one of your other reports did?
>>
>> The list_debug.c message goes away, but it still gets the GP fault.
> 
> Ok. I think there's a separate floppy.c bug introduced in commit
> 488211844e0c ("floppy: switch to one queue per drive instead of
> sharing a queue").
> 
> We do "put_disk()" on the disk device _before_ we then clean up the
> queue associated with that disk.
> 
> So maybe this trivial patch is in order?
> 
> Again - UNTESTED. Jens, Vivek?

That survives load/unload 3 times.

Tested-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/