Re: [PATCH 1/9] Add yaffs Kconfig and Makefile

[Valdis . Kletnieks]

On Thu, 04 Nov 2010 05:53:16 +1300, cdhmanning@xxxxxxxxx said:
> From: Charles Manning <cdhmanning@xxxxxxxxx>
> 
> Adding yaffs2 file system.

> +config YAFFS_DOES_ECC
> +	bool "Lets Yaffs do its own ECC"
> +	depends on YAFFS_FS && YAFFS_YAFFS1 && !YAFFS_9BYTE_TAGS
> +	default n
> +	help
> +	  This enables Yaffs to use its own ECC functions instead of using
> +	  the ones from the generic MTD-NAND driver.
> +
> +	  If unsure, say N.

Why does this exist at all? Are there any cases where the Yaffs ECC is better
than the MTD versions? If so, why aren't we fixing the MTD versions?

> +config YAFFS_DISABLE_TAGS_ECC
> +	bool "Disable YAFFS from doing ECC on tags by default"
> +	depends on YAFFS_FS && YAFFS_YAFFS2
> +	default n
> +	help
> +	  This defaults Yaffs to using its own ECC calculations on tags instead of
> +	  just relying on the MTD.
> +	  This behavior can also be overridden with tags_ecc_on and
> +	  tags_ecc_off mount options.
> +
> +	  If unsure, say N.

Similarly here - why would somebody want this?

> +config YAFFS_EMPTY_LOST_AND_FOUND
> +	bool "Empty lost and found on boot"
> +	depends on YAFFS_FS
> +	default n
> +	help
> +	  If this is enabled then the contents of lost and found is
> +	  automatically dumped at mount.

Wow.. Just.. wow.   Under what use case is this a good idea for a config option
as opposed to a mount option?

Attachment: pgp00000.pgp
Description: PGP signature