Re: Linux 2.6.37-rc1 (floppy module load: no device found)

From: Linus Torvalds
Date: Sat Nov 06 2010 - 10:53:18 EST


On Sat, Nov 6, 2010 at 5:16 AM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>
> While scanning the floopy code, I found one more instance of trying to
> access disk->queue pointer after doing put_disk() on gendisk. For some
> reason, floppy moule still loads/unloads fine. May be object is still
> around with right pointer values.

Yes - the normal use-after-free is fairly silent and only causes
problems if something re-allocates the same memory immediately, which
is quite a small race to hit under normal load.

But if you had had slab poisoning on, you'd have seen the same oops
Randy did (well, not the exact same one since the call trace would be
slightly different due to being from a different point, but _very_
similar).

Anyway, applied.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/