Re: Tracing Requirements (was: [RFC/Requirements/Design] h/w errorreporting)

From: Thomas Gleixner
Date: Wed Nov 10 2010 - 18:47:18 EST


On Wed, 10 Nov 2010, Steven Rostedt wrote:

> On Thu, 2010-11-11 at 00:12 +0100, Thomas Gleixner wrote:
>
> > Cramming both into the same session is just insane.
>
> That just doubled the overhead of the tracer.
>
> >
> > The first rule is "Keep It Simple!". Period.
>
> It's not that complex. Both Mathieu and I have implemented it. Really,
> I've seen a lot more complex code. Just because it does not fit into the
> CS101 course does not mean that it is totally complex.

I know you have implemented it and it's not about CS101, it's about
the insanity of what we have in the ftrace ringbuffer code. It does
not fulfil in any way the "Keep it Simple" requirement. Period.

And as I said earlier on IRC, you are trying to create the

ZeroImpactFilteringMultiSessionFlightRecorderOverwriteFifoSplicePerfMmapTracer

which is a nice wet dream, but completely unrealistic to achieve in
one go.

When I yelled at you folks in Boston last week and suggested to come
up with a syscall for buffers and the corresponding configuration
interfaces along with a unified record format, then I certainly did
not ask for the ZIFMSFROFSPMT thingy and a rewrite the world approach.

I told you back in 2008 that you need to think hard about the
interfaces and start with a reasonable simple implementation. Then
proceed from there.

The overall achievement so far is an ongoing ringbuffer pissing
contest, zero interfaces and lenghty explanations which kind of tracer
madness is preferred by whom.

I don't call this progress. If you did not get the message last week,
then you have it in writing now to digest as long as it takes:

Get your gear together and come up with sensible gradual approaches
which bring us to a better progress ratio than 0/year.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/