Re: [PATCH v4] msm: smd: Reduce driver log chatter

From: Joe Perches
Date: Thu Nov 11 2010 - 23:23:04 EST


On Thu, 2010-11-11 at 14:54 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes. Change some of these to pr_debug() to
> match their purpose, and remove others that aren't really useful.

Hi David.

> arch/arm/mach-msm/smd.c | 17 +++++++----------
> @@ -725,7 +727,7 @@ int smd_close(smd_channel_t *ch)
> {
> unsigned long flags;
>
> - pr_info("smd_close(%p)\n", ch);
> + pr_debug("smd_close(%p)\n", ch);

Why keep a printk for close without a printk for open?
I suggest removing this one too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/