Re: [PATCH 1/2] sysfs: Introducing sysfs_create_bin_group()

From: Greg KH
Date: Fri Nov 12 2010 - 14:52:55 EST


On Fri, Nov 12, 2010 at 11:38:17AM -0800, Dmitry Torokhov wrote:
> On Fri, Nov 12, 2010 at 11:29:58AM -0800, Greg KH wrote:
> > On Fri, Nov 12, 2010 at 07:18:38PM +0100, Stefan Achatz wrote:
> > > Implemented group functions for easier creation of multiple binary sysfs
> > > attributes similar to existing attribute_group handling functions.
> > > The code reuses struct attribute_group instead of inventing a new struct
> > > binary_attribute_group.
> > >
> > > Signed-off-by: Stefan Achatz <erazor_de@xxxxxxxxxxxxxxxxxxxxx>
> >
> > Looks good to me, nice job.
> >
> > Dmitry, do you want to take this through your tree as the mouse driver
> > change needs it? If so, feel free to do so and add a:
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > to the patch.
> >
> > If not, I'll be glad to take it, and the mouse driver change through my
> > tree if needed.
> >
> > Just let me know which is easier for you.
> >
>
> Actually the driver lives in hid so it's up to Jiri how he wants to
> handle this.

Ah. He's on vacation for a few weeks so I guess I'll take this for now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/