Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

[Kevin Hilman]

Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx> writes:

> Hi,
>
> On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
> <khilman@xxxxxxxxxxxxxxxxxxx> wrote:
>> Emeltchenko Andrei <Andrei.Emeltchenko.news@xxxxxxxxx> writes:
>>
>>> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>>>
>>> Define MDR1 register serial definitions used in serial and
>>> bluetooth drivers. Remove magic numbers there.
>>
>> Remove magic numbers where? ÂThis patch doesn't remove anything.
>
> We have code which is not yet upstream, it will come through Bluetooth
> subtree at some point, I am also going to remove magic in
> omapX/serial.c drivers in the next patches.
>
> Do you think I need to add those patches?

Not necessarly, but the comment should be a little more clear.
Something "subsequent patches will remove...."

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/