Re: [PATCH 1/2] perf-events: Add support for supplementary eventregisters v2

From: Andi Kleen
Date: Sat Nov 13 2010 - 04:10:45 EST


> Hrmm,. this doesn't really scale right wrt multiple extra_regs.
>
> You made the extra_regs thing fairly extensible, but the above doesn't
> really work well if there's multiple extra regs (say OFFCORE and
> LBR_CONFIG -- possibly even the two OFFCORE regs present on westmere).
>
> It basically needs a per-core state for each extra_reg possible.

It shouldn't be too hard to extend it to use a table. I didn't want
to do that for the first iteration. I guess it could be done as followons
once LBR is implemented.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/