Re: [stable] [git pull 2.6.36.stable] intel_idle patches for2.6.36.stable

From: Greg KH
Date: Mon Nov 15 2010 - 13:59:11 EST


On Mon, Nov 15, 2010 at 12:29:05PM -0500, Len Brown wrote:
> Hi Greg,
>
> please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-idle-2.6.36.git idle-release
>
> to sync 2.6.36.y with upstream changes to the intel_idle driver.
>
> After applying this series, 2.6.36.y and upstream intel_idle.c
> are identical.

That's nice, but why would I do this? I need git commit ids for the
upstream patches that went into Linus's tree, and they should only be
bug fixes or other stuff that is applicable for -stable.

> commit 935558a7fefe0a307618857ad8a06e8a485b3b47
> Author: Len Brown <len.brown@xxxxxxxxx>
> Date: Wed Jul 7 00:12:03 2010 -0400
>
> intel_idle: add initial Sandy Bridge support
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>

Is this patch really ok for -stable? What is the git commit id of it in
Linus's tree?

> commit 1768bd405dc30d4db74af5eb693d6c2d3389c5a6
> Author: Len Brown <len.brown@xxxxxxxxx>
> Date: Fri Oct 15 21:23:25 2010 -0400
>
> intel_idle: delete bogus data from cpuidle_state.power_usage
>
> The mW data in this field is a total fabrication
> and serves no purpose other than to mislead
> those who might see it in sysfs. Delete it.
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
>
> commit 645fd1ddc110eea7ab596b6fa27add5cff912e84
> Author: Len Brown <len.brown@xxxxxxxxx>
> Date: Fri Oct 15 20:43:06 2010 -0400
>
> intel_idle: simplify test for leave_mm()
>
> A run-time test to invoke leave_mm() for the deepest
> supported C-state is redundant, since the appropriate
> C-states already have flags with CPUIDLE_FLAG_TLB_FLUSHED set.
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>

Is this patch really for -stable?

> commit 27a52cf2d75b81e762c8fc41fd8fca3dac2aa8ca
> Author: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
> Date: Fri Sep 17 15:36:40 2010 -0700
>
> x86, mwait: Move mwait constants to a common header file
>
> We have MWAIT constants spread across three different .c files, for no
> good reason. Move them all into a common header file.
>
> Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
> Reviewed-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> LKML-Reference: <tip-*@git.kernel.org>

Why would this be ok for -stable?

While I understand you would like the driver to be the same in both
kernel versions, you still have to follow the normal -stable rules.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/