Re: suspicious code in linux/arch/arm/common/sa1111.c

From: Eric Miao
Date: Tue Nov 16 2010 - 04:10:29 EST


On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma@xxxxxxxxx> wrote:
> Hi!
>
> Is this good idea?
>
> Signed-off-by: Pavel Machek <pma@xxxxxxxxx>

Yep, obviously was a typo.

>
> diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
> --- linux.ofic//arch/arm/common/sa1111.c    Â2010-10-17 20:31:13.000000000 +0200
> +++ linux/arch/arm/common/sa1111.c   Â2010-11-05 10:44:17.000000000 +0100
> @@ -282,7 +312,7 @@
> Â Â Â Âfor (i = 0; i < 8; i++) {
> Â Â Â Â Â Â Â Âsa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
> Â Â Â Â Â Â Â Âsa1111_writel(ip0, mapbase + SA1111_INTPOL0);
> - Â Â Â Â Â Â Â if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
> + Â Â Â Â Â Â Â if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
> Â Â Â Â Â Â Â Â Â Â Â Âbreak;
> Â Â Â Â}
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/