Re: [patch 04/28] fs: change d_delete semantics

From: Tim Pepper
Date: Tue Nov 16 2010 - 19:16:23 EST


On Wed 17 Nov at 01:09:04 +1100 npiggin@xxxxxxxxx said:

> Documentation/filesystems/vfs.txt | 27 +++++++++++++--------------
> include/linux/dcache.h | 6 +++---

...minor nit:

There are white space changes in here around d_hash() and d_compare().

>
> Index: linux-2.6/Documentation/filesystems/vfs.txt
> ===================================================================
> --- linux-2.6.orig/Documentation/filesystems/vfs.txt 2010-11-17 00:50:54.000000000 +1100
> +++ linux-2.6/Documentation/filesystems/vfs.txt 2010-11-17 01:05:50.000000000 +1100
> @@ -841,9 +841,9 @@ the VFS uses a default. As of kernel 2.6
>
> struct dentry_operations {
> int (*d_revalidate)(struct dentry *, struct nameidata *);
> - int (*d_hash) (struct dentry *, struct qstr *);
> - int (*d_compare) (struct dentry *, struct qstr *, struct qstr *);
> - int (*d_delete)(struct dentry *);
> + int (*d_hash)(struct dentry *, struct qstr *);
> + int (*d_compare)(struct dentry *, struct qstr *, struct qstr *);
> + int (*d_delete)(const struct dentry *);
> void (*d_release)(struct dentry *);
> void (*d_iput)(struct dentry *, struct inode *);
> char *(*d_dname)(struct dentry *, char *, int);

> Index: linux-2.6/include/linux/dcache.h
> ===================================================================
> --- linux-2.6.orig/include/linux/dcache.h 2010-11-17 00:52:04.000000000 +1100
> +++ linux-2.6/include/linux/dcache.h 2010-11-17 01:05:50.000000000 +1100
> @@ -133,9 +133,9 @@ enum dentry_d_lock_class
>
> struct dentry_operations {
> int (*d_revalidate)(struct dentry *, struct nameidata *);
> - int (*d_hash) (struct dentry *, struct qstr *);
> - int (*d_compare) (struct dentry *, struct qstr *, struct qstr *);
> - int (*d_delete)(struct dentry *);
> + int (*d_hash)(struct dentry *, struct qstr *);
> + int (*d_compare)(struct dentry *, struct qstr *, struct qstr *);
> + int (*d_delete)(const struct dentry *);
> void (*d_release)(struct dentry *);
> void (*d_iput)(struct dentry *, struct inode *);
> char *(*d_dname)(struct dentry *, char *, int);

--
Tim Pepper <lnxninja@xxxxxxxxxxxxxxxxxx>
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/