Re: [PATCH v3 15/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses

From: Arnd Bergmann
Date: Wed Nov 17 2010 - 06:18:54 EST


On Wednesday 17 November 2010, Catalin Marinas wrote:
> >
> > It may make sense to mark it const volatile, as that's the most
> > permissive set of attributes possible (iow, it'll accept any pointer
> > without warning.) However, might be an idea to check what other
> > arches do.
>
> The majority of architectures use volatile and a few add both const
> and volatile.
>
> I usually use the generic headers as reference for function prototypes
> and that's just using volatile without a const (cc'ing Arnd for any
> view on this).

const volatile sounds right here, I can also change the generic header
if we agree to do the same in arm.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/