Re: [PATCH] add netdev led trigger

[Eric Cooper]

On Wed, Nov 17, 2010 at 08:58:43PM +0100, Pavel Machek wrote:
> I was hoping you'd comment on the ABI itself, too. It uses 
> 
> echo "foo bar baz" > file
> 
> to enable/disable specific events to be "displayed". More traditional
> interface would be 
> 
> echo disable > file_foo

The main arguments for using the single "mode" file are:
1. that's how it was implemented for OpenWrt, and there's a fair
   amount of userland (web admin tools, etc.) that groks it
2. it's only specifying a set of three possible values -- separate
   files seem like overkill

-- 
Eric Cooper             e c c @ c m u . e d u
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/