Re: [PATCH 06/13] writeback: bdi write bandwidth estimation

From: Andrew Morton
Date: Wed Nov 17 2010 - 18:09:26 EST


On Wed, 17 Nov 2010 12:27:26 +0800
Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> + w = min(elapsed / (HZ/100), 128UL);

I did try setting HZ=10 many years ago, and the kernel blew up.

I do recall hearing of people who set HZ very low, perhaps because
their huge machines were seeing performance prolems when the timer tick
went off. Probably there's no need to do that any more.

But still, we shouldn't hard-wire the (HZ >= 100) assumption if we
don't absolutely need to, and I don't think it is absolutely needed
here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/