Re: [RESEND] [PATCH] Input: add appleir USB driver

From: Bastien Nocera
Date: Wed Nov 17 2010 - 23:19:37 EST


On Thu, 2010-10-07 at 20:39 -0400, Jarod Wilson wrote:
> On Thu, Sep 30, 2010 at 04:51:30PM +0100, Bastien Nocera wrote:
> > On Thu, 2010-09-30 at 08:47 -0700, Dmitry Torokhov wrote:
> > > Bastien,
> ...
> > > I'll try
> > > to get the driver in .37 but after that we should probably move it
> > > over to the new IR infrastructure...
> >
> > I'm not sure what that would bring us, nor do I have any experience in
> > using the ir-core. From what I understood, it still needed fleshing out.
>
> There are a few things that still need fleshing out, but nothing really
> that should have any major impact on a potential port of this driver.
>
> Off the top of my head, the main thing it would give you is the ability to
> upload your own keymap for the receiver.

You could already change the keymap...

> Then someone wanting to use more
> than 6 buttons

But only for the 6 buttons supported.

> or whatever it is might still be able to get the benefits
> of in-kernel decoding with everything coming through the input layer,
> rather than using lirc or the like.

I see very little benefits myself (I mean, unless you're adamant that
you want to use a remote that's not intended for that computer, but we
already have lirc user-space driver for doing that), and it would remove
metadata from the events, so we couldn't do "remote filtering" (each
remote has a semi-random UID, which gets passed in with the events).

When the appleir patch was finally accepted (which means I need to get
off my arse and do the changes Oliver mentioned), working on UID
filtering is next on my list of TODOs.

Cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/