Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mappingearly during boot
From: Tejun Heo
Date: Thu Nov 18 2010 - 03:40:26 EST
Hey, Ingo.
On 11/18/2010 09:30 AM, Ingo Molnar wrote:
> This patch is still _WAY_ too large.
Really? Alright, I'll split it further.
> Also, these:
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
> Are rather ugly.
Yeah, what they do is ugly. It gets less uglier after the patchset.
I'll see if some of them can be dropped but I don't think putting them
inside ifdef'd inline functions necessarily improves things. It often
just makes things more difficult to follow.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/