Re: [PATCH] hwmon: (lm95241) Rewritten without using macros

From: Davide Rizzo
Date: Thu Nov 18 2010 - 10:54:12 EST


2010/11/18 Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>:
> Hi Davide,
>

Hi Guenter,

> Looks like you still have trouble with line wraps. You might want to get this fixed;
> having to figure out why the patch does not apply is a bit annoying.
>

You said me that attaching the patch to the mail is not correct.
First times I copy/pasted from kate, that broke tabs.
The last time I copy/pasted from kwrite, that seemed me correct (but
you're saying me that it isn't).
I'm using gmail, please explain me how to attach a patch to the e-mail.

> Moving include statements around is just a whitespace change and should be avoided.
> Also, you added a blank line at the end of the file which causes a git whitespace error
> when applying the patch.
>
> No need to retransmit. I fixed both and applied the patch with a couple of additional
> formatting changes to make the file checkpatch clean.
>
> Thanks,
> Guenter
>

I thank you,
Davide.


--
All difficult problems have a simple solution. That is wrong. [A. Einstein]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/