Re: [PATCH 05 of 66] compound_lock

[Linus Torvalds]

On Thu, Nov 18, 2010 at 3:49 AM, Mel Gorman <mel@xxxxxxxxx> wrote:
>> +
>> +static inline void compound_lock_irqsave(struct page *page,
>> +                                      unsigned long *flagsp)
>> +{
>> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> +     unsigned long flags;
>> +     local_irq_save(flags);
>> +     compound_lock(page);
>> +     *flagsp = flags;
>> +#endif
>> +}
>> +
>
> The pattern for spinlock irqsave passes in unsigned long, not unsigned
> long *. It'd be nice if they matched.

Indeed. Just make the thing return the flags the way the normal
spin_lock_irqsave() function does.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/