Re: [PATCH 4/4] net: caif: spi: fix potential NULL dereference

From: David Miller
Date: Thu Nov 18 2010 - 13:35:58 EST


From: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
Date: Thu, 18 Nov 2010 21:17:05 +0300

> alloc_netdev() is not checked here for NULL return value. dev is
> check instead. It might lead to NULL dereference of ndev.
>
> Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
> ---
> Compile tested.
> Maybe dev is also must be checked here, but it looks like a trivial typo.

Definitely looks correct to me, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/