Re: fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock

From: Joel Becker
Date: Thu Nov 18 2010 - 18:43:25 EST


On Tue, Nov 02, 2010 at 11:36:02PM +0100, David Sterba wrote:
> coccinelle check scripts/coccinelle/locks/call_kern.cocci found that
> in fs/ocfs2/dlm/dlmdomain.c an allocation with GFP_KERNEL is done
> with locks held:
>
> dlm_query_region_handler
> spin_lock(dlm_domain_lock)
> dlm_match_regions
> kmalloc(GFP_KERNEL)
>
> Change it to GFP_ATOMIC.
>
> Signed-off-by: David Sterba <dsterba@xxxxxxx>
> CC: Joel Becker <joel.becker@xxxxxxxxxx>
> CC: Mark Fasheh <mfasheh@xxxxxxxx>
> CC: ocfs2-devel@xxxxxxxxxxxxxx

This patch is now in the fixes branch of ocfs2.git.

Joel

--

"Behind every successful man there's a lot of unsuccessful years."
- Bob Brown

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/