Re: [PATCH 02 of 66] mm, migration: Fix race between shift_arg_pagesand rmap_walk by guaranteeing rmap_walk finds PTEs created within thetemporary stack

From: Linus Torvalds
Date: Fri Nov 19 2010 - 13:25:17 EST


On Fri, Nov 19, 2010 at 9:38 AM, Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote:
>
> We decided the kmalloc was ok, but Linus didn't like this approach. I
> kept it in my tree because I didn't want to remember when/if to add the
> special check in the accurate rmap walks. I find it simpler if all
> rmap walks are accurate by default.

Why isn't the existing cheap solution sufficient?

My opinion is still that we shouldn't add the expense to the common
case, and it's the uncommon case (migration) that should just handle
it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/