[PATCH] Shrink fanotify_event_metadata by 32 bits

From: Alexey Zaytsev
Date: Sat Nov 20 2010 - 00:07:06 EST


There seems to be no point wasting 32 bits for either the event version or length

Signed-off-by: Alexey Zaytsev <alexey.zaytsev@xxxxxxxxx>
---

Hi.

While I'm working on the file modification events,
please consider this patch. It obviously breaks
the userspace ABI. But maybe that's acceptable, given
that no kernel has ever been released with the old ABI.

And the users only need to recompile their code, without
changing anything.

If we agree that this change is desirable, please make sure
it makes it to Linus before the release. ;)


include/linux/fanotify.h | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/linux/fanotify.h b/include/linux/fanotify.h
index 0f01214..9a7986f 100644
--- a/include/linux/fanotify.h
+++ b/include/linux/fanotify.h
@@ -86,10 +86,11 @@
#define FANOTIFY_METADATA_VERSION 2

struct fanotify_event_metadata {
- __u32 event_len;
- __u32 vers;
- __aligned_u64 mask;
+ __u16 event_len;
+ __u8 vers;
+ __u8 reserved;
__s32 fd;
+ __aligned_u64 mask;
__s32 pid;
};


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/