Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'

From: David Brownell
Date: Sat Nov 20 2010 - 17:59:37 EST




--- On Sat, 11/20/10, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> > +        void
> *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */

Reads like a bad patch to me. Fix the bug,
don't just silence GCC. Or at least use
a better comment mentioning a constness
cast problems).

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/