Re: Bcache version 9

From: Greg KH
Date: Sun Nov 21 2010 - 20:12:36 EST


On Sun, Nov 21, 2010 at 06:09:34AM -0800, Kent Overstreet wrote:
> +++ b/Documentation/bcache.txt

For new sysfs files, please create Documentation/ABI files.

> +All configuration is done via sysfs. To use sde to cache md1, assuming the
> +SSD's erase block size is 128k:
> +
> + make-bcache -b128k /dev/sde
> + echo "/dev/sde" > /sys/kernel/bcache/register_cache
> + echo "<UUID> /dev/md1" > /sys/kernel/bcache/register_dev

/sys/kernel/bcache/? Really?

Come on, shouldn't this be somewhere else? You only have 1 file here,
right?

Shouldn't it be a configfs file instead as that is what you are doing?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/