Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers

[Mike Frysinger]

On Mon, Nov 22, 2010 at 16:58, Andrew Morton wrote:
> On Sun, 21 Nov 2010 19:24:21 -0500 Mike Frysinger wrote:
>> This header uses things like __be32, so pull in linux/types.h.
>>
>> Further, it uses BLOCK_SIZE, so pull in linux/fs.h.
>>
>> --- a/include/linux/romfs_fs.h
>> +++ b/include/linux/romfs_fs.h
>> @@ -1,6 +1,9 @@
>> Â#ifndef __LINUX_ROMFS_FS_H
>> Â#define __LINUX_ROMFS_FS_H
>>
>> +#include <linux/types.h>
>> +#include <linux/fs.h>
>> +
>> Â/* The basic structures of the romfs filesystem */
>>
>> Â#define ROMBSIZE BLOCK_SIZE
>
> Better changelogs please.
>
> Does this fix any build error? ÂIf so, is that build error present in
> 2.6.36 or earlier?

headers should include the headers that define types/things that the
header itself needs
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/