Re: [PATCH 06/13] writeback: bdi write bandwidth estimation

From: Wu Fengguang
Date: Wed Nov 24 2010 - 08:46:52 EST


On Wed, Nov 24, 2010 at 09:42:09PM +0800, Peter Zijlstra wrote:
> On Wed, 2010-11-24 at 21:20 +0800, Wu Fengguang wrote:
> > > (jiffies - bdi->write_bandwidth_update_time < elapsed)
> >
> > this will be true if someone else has _done_ overlapped estimation,
> > otherwise it will equal:
> >
> > jiffies - bdi->write_bandwidth_update_time == elapsed
> >
> > Sorry the comment needs updating.
>
> Right, but its racy as hell..

Yeah, for N concurrent dirtiers, plus the background flusher, only
one is able to update write_bandwidth[_update_time]..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/