RE: [PATCH 8/9] scsi: megaraid_sas - Driver take some workloadsfrom FW

[Yang, Bo]

James,

Our megaraid sas driver only implemented the part of the XOR calculation and copy capability(moving data between 2 buffers) for the RAID5 cmds which FW asks driver to do.  When fw received very heavy I/Os and there are high pending cmds in FW, fw will ask the help from driver to finish some cmds and reduce the fw heavy load.  Driver will only do part of the RAID5 (not take the jobs) from FW.  Driver is not duplicating Parity calculation done on dm/md.

Thanks,

Bo Yang  



-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] 
Sent: Friday, November 19, 2010 12:53 PM
To: Yang, Bo
Cc: 'linux-scsi@xxxxxxxxxxxxxxx'; 'akpm@xxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx'; Tomas Henzl
Subject: Re: [PATCH 8/9] scsi: megaraid_sas - Driver take some workloads from FW

On Fri, 2010-11-19 at 10:43 -0700, Yang, Bo wrote:
> Driver added the new feature to take some of the workloads from FW to increase
> performance of the iMR controller.  FW assigns the read cmds back to driver
> which will increase the performance for megaraid sas iMR controller.

Just on a process note: you don't have to cc me at every known
address ... I do read linux-scsi ...

My first take on this patch is that you're basically passing data back
to the kernel for RAID-N parity calculations.  This effectively makes
your RAID one of those pseudo HW ones.  In which case, why not simply
abandon the HW raid piece and have it all done by DM/MD, which are well
optimised for all types of RAID?  The reason for asking is that we're
trying to reduce the number of in-kernel raid implementations and this
is going in the wrong direction.

James


¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_