Re: [PATCH] printk: use this_cpu_{read|write} api on printk_pending

From: Peter Zijlstra
Date: Fri Nov 26 2010 - 11:29:48 EST


On Fri, 2010-11-26 at 17:22 +0100, Eric Dumazet wrote:
> [PATCH] printk: use this_cpu_{read|write} api on printk_pending
>
> __get_cpu_var() is a bit inefficient, lets use __this_cpu_read() and
> __this_cpu_write() to manipulate printk_pending.
>
> printk_needs_cpu(cpu) is called only for the current cpu :
> Use faster __this_cpu_read().
>
> remove the redondant unlikely on (cpu_is_offline(cpu)) test
>
> # size kernel/printk.o*
> text data bss dec hex filename
> 9942 756 263488 274186 42f0a kernel/printk.o.new
> 9990 756 263488 274234 42f3a kernel/printk.o.old


Thanks, queued!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/