Re: VT console need rewrite

From: Theodore Tso
Date: Sun Nov 28 2010 - 08:24:25 EST



On Nov 28, 2010, at 5:57 AM, Microcai wrote:

> Hi, there
>
> I'm implementing the UNICODE font of the framebuffer console, (see
> http://lkml.org/lkml/2010/11/26/50 in case you do not got my email). But
> current vt code is too bugy, too many direct assumes about vt buffer,
> This makes me so hard to hack. There is TODO telling me to add UNICODE
> support, but no room for such code, that's why my patch is so tricky.
>
> And the code itself, if you'll excuse me, it isn't as beautiful as rest
> of the kernel.
> So, it really really need a clean rewrite.I'm ganna take is hard job.
> And, please tell me if is worth to do so.

Yes, the console is code is very old. But please be aware that lots of code (both in the kernel and in userspace) has dependencies upon how the code behaves. So changing it in a way that does not break backwards compatibility is hard. i.e., it is hard to hack for a reason.

I would recommend an incremental rewrite (i.e., one patch at a time), as opposed to a rewrite from scratch. Because people will want to be assured that things haven't broken in a horrible way as a result of a complete rewrite...

-- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/