Re: [PATCH net-next-2.6 06/19 v5] can: EG20T PCH: Fix endianness issue

From: Tomoya MORINAGA
Date: Sun Nov 28 2010 - 19:19:30 EST


On Friday, November 26, 2010 6:52 PM, Marc Kleine-Budde wrote :

> In an OOM situation the system is under pressure anyway. On low end
> systems it not good to print a message to the log. AFAICS no other can
> driver does this.

Does the above mean it doesn't have to process for returned value of
pch_can_rx_msg_lost like below?
> + pch_can_rx_msg_lost(ndev, obj_num);
> + rcv_pkts++;
> + quota--;

> AFAICS no other can driver does this.
I can see ti_hecc.c calls dev_err when alloc_can_err_skb fails.

Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/